resource/alicloud_ess_scaling_group: add alb_server_group & resource_group_id and disable group retry fault tolerance. #7273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -336,67 +390,85 @@ func resourceAliyunEssScalingGroupUpdate(d *schema.ResourceData, meta interface{ | |||
| } | |||
| d.SetPartial("tags") | |||
| } | |||
| if d.HasChange("resource_group_id") { | |||
There was a problem hiding this comment.
ResourceGroupId 应该不允许传空值的，可以测试看看
There was a problem hiding this comment.
我这边测试增加 ResourceGroupId 设置“” 也是可以跑通测试的
ResourceGroupId 不传的话，会使用默认资源组Id
| } | ||
|
|
||
| if d.HasChange("health_check_type") { | ||
| request.HealthCheckType = d.Get("health_check_type").(string) | ||
| d.SetPartial("health_check_type") |
There was a problem hiding this comment.
把所有的 d.SetPartial 去掉，已经废弃即将移除了
| "removal_policies": []string{"OldestInstance", "NewestInstance"}, | ||
| "launch_template_id": "${alicloud_ecs_launch_template.default1.id}", | ||
| "launch_template_version": "Latest", | ||
| "alb_server_group": []map[string]string{{ |
There was a problem hiding this comment.
增加一步测试alb_server_group置空
…group_id and disable group retry fault tolerance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_group_id and disable group retry fault tolerance.