Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_arms_dispatch_rule: add new attribute notify_template and data-source/alicloud_arms_dispatch_rules: add new attribute notify_template #7909

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

icloudnote
Copy link
Contributor

添加 arms 通知模版

@icloudnote icloudnote force-pushed the arms_notify_template branch 4 times, most recently from e1e6161 to b46f412 Compare December 5, 2024 07:26
@icloudnote icloudnote changed the title resource/alicloud_arms_dispatch_rule: add new attribute notify_template resource/alicloud_arms_dispatch_rule and data-source/alicloud_arms_dispatch_rules add new attribute notify_template Dec 5, 2024
@icloudnote
Copy link
Contributor Author

PR title 已经更改, 帮忙再走一个CI, 看看还有啥问题.

@icloudnote icloudnote force-pushed the arms_notify_template branch from b46f412 to ff71bce Compare December 5, 2024 08:46
@icloudnote icloudnote changed the title resource/alicloud_arms_dispatch_rule and data-source/alicloud_arms_dispatch_rules add new attribute notify_template resource/alicloud_arms_dispatch_rule: add new attribute notify_template and data-source/alicloud_arms_dispatch_rules: add new attribute notify_template Dec 5, 2024
@icloudnote icloudnote force-pushed the arms_notify_template branch 5 times, most recently from e15eb9c to 58ee349 Compare December 7, 2024 05:15
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@@ -81,6 +94,7 @@ The following arguments are supported:
* `group_rules` - (Required) Sets the event group. See [`group_rules`](#group_rules) below. It will be ignored when `dispatch_type = "DISCARD_ALERT"`.
* `label_match_expression_grid` - (Required) Sets the dispatch rule. See [`label_match_expression_grid`](#label_match_expression_grid) below.
* `notify_rules` - (Required) Sets the notification rule. See [`notify_rules`](#notify_rules) below. It will be ignored when `dispatch_type = "DISCARD_ALERT"`.
* `notify_template` - (Optional) Sets the notification template. See [`notify_template`](#notify_template) below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要添加可用版本信息,Available since v1.236.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经添加好了可用版本信息.

@icloudnote icloudnote force-pushed the arms_notify_template branch from 58ee349 to 0d74d33 Compare December 8, 2024 11:54
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@icloudnote icloudnote force-pushed the arms_notify_template branch from 0d74d33 to a11385c Compare December 9, 2024 02:08
@icloudnote
Copy link
Contributor Author

示例的报错已经修复.

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@icloudnote icloudnote force-pushed the arms_notify_template branch from a11385c to 00cfde5 Compare December 9, 2024 12:20
Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@icloudnote
Copy link
Contributor Author

我这边将文档里面的示例执行了一下, 应该没有问题才对的. 难道是因为没有加depends_on, 导致先获取获取数据了吗?

@ChenHanZhang
Copy link
Collaborator

应该是的,datasource里需要引用下上个resource的id。这个问题我在后续的pr中修复吧

@ChenHanZhang ChenHanZhang merged commit 7e28484 into aliyun:master Dec 13, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants