Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab can't swtich at online #313

Closed
twofisher opened this issue Apr 24, 2015 · 3 comments
Closed

tab can't swtich at online #313

twofisher opened this issue Apr 24, 2015 · 3 comments

Comments

@twofisher
Copy link
Contributor

opencms 9.5 formattorr tabs-standard.jsp is work fine on offline,but don't work on online,it can't switched,the HTML outputed by tab-standar.jsp shows div class="tab-pane" hasn't "id" attrubite., it should be equal to href attribue of <a tag.

opencms

this picture shows the HTML output by tab formattor.

@twofisher
Copy link
Contributor Author

ok,just add a tag="div id=" param to <cms:container,the tab-standard.jsp will work well

@twofisher twofisher reopened this May 21, 2015
@twofisher
Copy link
Contributor Author

after add tag="div id=xxx" to Container tag,the tab-standart works,but the html it output add id also to < / div id="xxx"> ,it isn't a well fine HTML document

@dSeidel
Copy link
Contributor

dSeidel commented Jun 17, 2015

Hi, the problem is, that the ids on div's generated by the container tag are only attached offline (for nested containers).
You solved the problem. But, the solution may influence ADE-functionality.
OpenCms 9.5.2 will provide a fixed formatter that introduces an additional div. Here's the part containing the fixed lines:

<div class="tab-v1">
    <ul class="nav nav-tabs">
        <c:forEach var="label" items="${content.valueList.Label}" varStatus="status">
            <li class="${status.first? 'active':''}"><a href="#${cms.element.instanceId}-tab-${status.count}" data-toggle="tab">${label}</a></li>
        </c:forEach>
    </ul>

    <div class="tab-content">
        <c:forEach var="label" items="${content.valueList.Label}" varStatus="status">
            <div id="${cms.element.instanceId}-tab-${status.count}" class="tab-pane ${status.first? 'active':''}">
                <cms:container name="tab-container${status.count}" type="layoutrowsonly" maxElements="2">
                    <div class="alert alert-warning fade in">
                        <h4><fmt:message key="bootstrap.tabs.emptycontainer.headline"/></h4>
                        <p><fmt:message key="bootstrap.tabs.emptycontainer.text"/></p>           
                    </div>                  
                </cms:container>
            </div>
        </c:forEach>
    </div><!--/tab-content-->
</div><!--/tab-v1-->

@dSeidel dSeidel closed this as completed Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants