refactor: move from "request" to "node fetch" #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favna
changed the title
|
🎉 This PR is included in version 6.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
favna
added a commit
to favna/all-contributors-cli
that referenced
this pull request
Aug 14, 2020
This accidentally got in as I was copypasting code as part of all-contributors#277
Berkmann18
pushed a commit
that referenced
this pull request
Aug 16, 2020
This accidentally got in as I was copypasting code as part of #277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I recently installed this CLI and got the helpful message from yarn that it was still using the
requestpackage which has been deprecated (see request/request#3142). To resolve this I rewrote the parts using request to instead use thenode-fetchpackage.Why:
As stated above, request has been deprecated. node-fetch is a good alternative that also didn't require too many changes to the code.
How:
By changing the code pretty much. What is there to say really. I have a lot of experience with node-fetch so I knew what to do and it helped that request was already being promisified.
Checklist: