Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down security on bot repo to allow write access to contributors #147

Open
jakebolam opened this issue Feb 15, 2019 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@jakebolam
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Maintainers should have write access to all repos, they currently do not have write access to the bot (due to security concerns).

Describe the solution you'd like
Lock down CI to only inject AWS secrets on master pushes.
Lock down AWS credentials to have the minimum credentials required for deployment.

Additional context
We don't pass environment variables (Secrets) to forked builds. Which is how we can currently have users fork the repo, put up pull requests and run the test builds.

@jakebolam jakebolam added the enhancement New feature or request label Feb 15, 2019
@jakebolam
Copy link
Contributor Author

We have attempted this IAM config to no avail.

serverless/serverless#588 (comment)

Error messages from serverless deploy are fairly useless, the exact minimum resources required for deploy are unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant