Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proc_macro_hack #43

Closed
sonro opened this issue Nov 18, 2022 · 1 comment · Fixed by #45
Closed

Remove proc_macro_hack #43

sonro opened this issue Nov 18, 2022 · 1 comment · Fixed by #45
Assignees
@sonro

Comments

@sonro
Copy link
Collaborator

sonro commented Nov 18, 2022 •
edited
Loading

The proc_macro_hack crate is no longer needed since rustc 1.45.0. As this library doesn't support compiler versions before 1.56.1, the dependency should be removed and replaced with the native version.

This would fix the rust analyzer errors highlighted in #1, remove an unnecessary dependency, and combine the dotenvy_macro and dotenvy_codegen_impl crates.
@sonro sonro added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 18, 2022
@sonro sonro mentioned this issue Dec 5, 2022
Closed
@sonro sonro removed help wanted Extra attention is needed good first issue Good for newcomers labels Dec 5, 2022
@sonro sonro self-assigned this Dec 5, 2022
@sonro sonro mentioned this issue Dec 6, 2022
Merged
@allan2 allan2 closed this as completed in #45 Dec 6, 2022
@allan2
Copy link
Owner

allan2 commented Dec 6, 2022

Thank you!

I've moved the legacy code to allan2/dotenvy-codegen-impl. just adding a deprecation notice. Let me know if anything should be changed before I publish a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonro sonro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove macro dependencies sonro/dotenvy
2 participants
@allan2 @sonro