Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing #56

Closed
sonro opened this issue Dec 14, 2022 · 1 comment · Fixed by #57
Closed

Contributing #56

sonro opened this issue Dec 14, 2022 · 1 comment · Fixed by #57
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sonro
Copy link
Collaborator

sonro commented Dec 14, 2022

I feel we should create better contributing guidelines for this project. I know its only a small crate, but it would be best if issues were opened before PRs and the current info in the README just says "Contributions and PRs are very welcome!"

I personally think a CONTRIBUTING.md file is the way to go, with info on how to pass CI, (testing, clippy, formatting etc). Also updating the README to ask contributors to open an issue first and read the file would be a good idea.

@sonro sonro self-assigned this Dec 14, 2022
@sonro sonro added the documentation Improvements or additions to documentation label Dec 14, 2022
@allan2
Copy link
Owner

allan2 commented Dec 14, 2022

Sounds good!

Some thoughts:

  • welcoming tone (Axum does this well, as does this user)
  • a suggestion to open issues to solicit feedback before making large changes (paraphrased from here)
  • mention CI (probably not necessary to write instructions but it would be good to mention. at least in passing)
  • update CHANGELOG
  • encourage asking for help (either in issues and/or discussions?). This could be caused by the docs missing something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants