Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove maxShardSize from BigCache #293

Closed
janisz opened this issue Oct 27, 2021 · 1 comment · Fixed by #294
Closed

Remove maxShardSize from BigCache #293

janisz opened this issue Oct 27, 2021 · 1 comment · Fixed by #294
Labels
hacktoberfest

Comments

@janisz
Copy link
Collaborator

janisz commented Oct 27, 2021

It looks like BigCache.maxShardSize is only set but never queried so it can be safely deleted.

bigcache/bigcache.go

Line 22 in c2b72fe

maxShardSize uint32

bigcache/bigcache.go

Line 66 in c2b72fe

maxShardSize: uint32(config.maximumShardSizeInBytes()),

@penthaapatel penthaapatel mentioned this issue Oct 28, 2021
Merged
@penthaapatel
Copy link
Contributor

Hi @janisz! Just created a PR to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove maxShardSize from BigCache penthaapatel/bigcache
2 participants
@janisz @penthaapatel