Set health check path to root (/) if empty

Fixes a regression introduced in 65c47ca.
When healthchekc has not defined path in Marathon
then we should map it to root path (/).

Fixes: #235

Author: Mark Selby

consul/consul.go

@@ -326,13 +326,13 @@ func (c *Consul) marathonToConsulChecks(task *apps.Task, healthChecks []apps.Hea
 			Status:   "passing",
 		}
 
-                if check.Path == nil {
-                        check.Path = "/"
-                }
-
 		switch check.Protocol {
 		case "HTTP", "HTTPS", "MESOS_HTTP", "MESOS_HTTPS":
-			if parsedURL, err := url.ParseRequestURI(check.Path); err == nil {
+			path := "/"
+			if check.Path != "" {
+				path = check.Path
+			}
+			if parsedURL, err := url.ParseRequestURI(path); err == nil {
 				if check.Protocol == "HTTP" || check.Protocol == "MESOS_HTTP" {
 					parsedURL.Scheme = "http"
 				} else {
@@ -345,7 +345,7 @@ func (c *Consul) marathonToConsulChecks(task *apps.Task, healthChecks []apps.Hea
 				log.WithError(err).
 					WithField("Id", task.AppID.String()).
 					WithField("Address", serviceAddress).
-					Warnf("Could not parse provided path: %s", check.Path)
+					Warnf("Could not parse provided path: %s", path)
 			}
 		case "TCP", "MESOS_TCP":
 			consulCheck.TCP = fmt.Sprintf("%s:%d", serviceAddress, port)

consul/consul_test.go

@@ -809,7 +809,7 @@ func TestMarathonTaskToConsulServiceMapping(t *testing.T) {
 	assert.Equal(t, []string{"marathon", "public", "marathon-task:someTask"}, service.Tags)
 	assert.Equal(t, 8090, service.Port)
 	assert.Nil(t, service.Check)
-	assert.Equal(t, 5, len(service.Checks))
+	assert.Equal(t, 6, len(service.Checks))
 
 	assert.Equal(t, consulapi.AgentServiceChecks{
 		{
@@ -818,6 +818,12 @@ func TestMarathonTaskToConsulServiceMapping(t *testing.T) {
 			Timeout:  "20s",
 			Status:   "passing",
 		},
+		{
+			HTTP:     "http://127.0.0.6:8090/",
+			Interval: "60s",
+			Timeout:  "20s",
+			Status:   "passing",
+		},
 		{
 			HTTP:     "https://127.0.0.6:8090/secure/health?with=query",
 			Interval: "50s",