-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupBy via plywood #572
Labels
Comments
adrianmroz
added
help wanted
We are open for contribution
question
Technical question
labels
Feb 22, 2020
We should check that before some work in #472 |
Merged
Technical debt to repay:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently when we're generating query in https://github.com/allegro/turnilo/blob/master/src/common/utils/query/visualization-query.ts we get nested set of topN's. Thats because we allow for custom sorts and splits on splits. It is not possible to generate group-by query with different sorts on different split dimensions. Probably it is not possible to get top N values in respective splits.
We should check with what constraints we can generate group-by query.
That way we could generate faster queries for few common cases and for example let user pick bigger limits. Common split values would also let us create stacked bar charts/mosaic plots.
If that would be possible we need to discuss how present this option to the user. I don't think it should be transparent because changing sort could change limit settings behind user back. Probably different visualisations? Maybe different mode altogether?
The text was updated successfully, but these errors were encountered: