Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupBy via plywood #572

Open
adrianmroz opened this issue Feb 22, 2020 · 2 comments
Open

GroupBy via plywood #572

adrianmroz opened this issue Feb 22, 2020 · 2 comments
Labels
help wanted We are open for contribution question Technical question

Comments

@adrianmroz
Copy link
Collaborator

Currently when we're generating query in https://github.com/allegro/turnilo/blob/master/src/common/utils/query/visualization-query.ts we get nested set of topN's. Thats because we allow for custom sorts and splits on splits. It is not possible to generate group-by query with different sorts on different split dimensions. Probably it is not possible to get top N values in respective splits.

We should check with what constraints we can generate group-by query.

That way we could generate faster queries for few common cases and for example let user pick bigger limits. Common split values would also let us create stacked bar charts/mosaic plots.

If that would be possible we need to discuss how present this option to the user. I don't think it should be transparent because changing sort could change limit settings behind user back. Probably different visualisations? Maybe different mode altogether?

@adrianmroz adrianmroz added this to the next milestone Feb 22, 2020
@adrianmroz adrianmroz added help wanted We are open for contribution question Technical question labels Feb 22, 2020
@adrianmroz
Copy link
Collaborator Author

We should check that before some work in #472

@mkuthan mkuthan removed this from the next milestone Apr 10, 2020
@adrianmroz-allegro adrianmroz-allegro mentioned this issue Mar 2, 2021
@adrianmroz
Copy link
Collaborator Author

Technical debt to repay:

  • Gird #712 (comment)
  • Gird #712 (comment) (This one needs some refactor. Logic used to calculate layout is distributed across whole Table component and make it hard to extract. Could more some of that composition)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We are open for contribution question Technical question
Projects
None yet
Development

No branches or pull requests

2 participants