Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion filter does not filter out 'null' #868

Closed
mkuthan opened this issue Mar 7, 2022 · 1 comment · Fixed by #869
Closed

Exclusion filter does not filter out 'null' #868

mkuthan opened this issue Mar 7, 2022 · 1 comment · Fixed by #869

Comments

@adrianmroz-allegro
Copy link
Contributor

We don't have any guarantees about values inside string dimensions. They can hold null or any other value.

Right now we eagerly convert all values to string here
We should do this more lazy, so we keep original values and show stringified version on UI. Of course that will lead to confusion if non-string value evaluates to existing string value. But I thinks that's on dataset administrator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants