Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When attempting to send a request with event size exceeding max_req_size, several subsequent events are also lost. #1316

Open
Legyan opened this issue Aug 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Legyan
Copy link

Legyan commented Aug 27, 2024

Describe the bug

The issue occurs here:
https://github.com/allegroai/clearml/blob/master/clearml/backend_api/session/session.py#L561
If any line in req_data exceeds the max_req_size, a MaxRequestSizeError is raised, and the following lines are not sent.
Moreover, the error message from the exception does not appear in the logs because raise_on_errors=False is set here:
https://github.com/allegroai/clearml/blob/master/clearml/backend_interface/metrics/interface.py#L244

To reproduce

Simultaneously send several plots, one of which exceeds the max_req_size.

Expected behaviour

The ClearML SDK should not lose events that do not exceed the max_req_size, and it should log the loss of events that are larger than max_req_size.

Environment

  • Server type - self hosted
  • ClearML SDK Version - v1.16.3
  • ClearML Server Version - v1.15
  • Python Version - 3.11
  • OS - Macos
@Legyan Legyan added the bug Something isn't working label Aug 27, 2024
@ainoam
Copy link
Collaborator

ainoam commented Aug 27, 2024

Thanks for reporting @Legyan - We'll try to address in a near release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants