Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error when using links in the wrong function #1332

Open
morzahavi opened this issue Sep 24, 2024 · 2 comments
Open

Print error when using links in the wrong function #1332

morzahavi opened this issue Sep 24, 2024 · 2 comments

Comments

@morzahavi
Copy link

morzahavi commented Sep 24, 2024

Proposal Summary

I would suggest adding an informative error when using links inside dataset.add_files() instead of using the appropriate dataset.add_external_files

Motivation

It took me some time to figure out whats wrong since I wasn't aware of the function for external files, and chat GPT was not clever enough to suggest it even though I used links in my question. The notification I got was something like "failed to add files..."

Related Discussion

If this continues a slack thread, please provide a link to the original slack thread.

@ainoam
Copy link
Collaborator

ainoam commented Sep 25, 2024

Thanks for suggesting @morzahavi - Would you care to put in a PR? any addition to streamline development is wholeheartedly welcome.

@morzahavi
Copy link
Author

Thanks for suggesting @morzahavi - Would you care to put in a PR? any addition to streamline development is wholeheartedly welcome.

Added -> 50ad7b0

LMK if not clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants