-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add features to beam search that are supported in other libraries #5205
Comments
Looks like #5113 is asking for 3 as well. |
These would be all be great! Looks like you've got 1-3 covered (I'll finish reviewing shortly), and I think 4 could be implemented as a |
I do think 4 could be a |
Actually I really like this idea of having a |
Is your feature request related to a problem? Please describe.
Other libraries, like
transformers
andfairseq
, have implemented several beam search options that aren't included in AllenNLP, which would be useful to have. For instance:All 4 of these are used in the BART paper, but the generic AllenNLP beam search code does not support them. I have not run the exact training config for the CNN/DailyMail BART model, but I have run one almost identical to it, and I could not reproduce the BART paper's results without implementing 1-3 myself. 4 is more complicated and I haven't implemented it yet.
Describe the solution you'd like
I think there are workarounds for all 4 problems that could be implemented in the model code, but they all seem generically useful enough to include them in the beam search code.
If you would like, I can create a separate issue for each of the above requests (although I think 2 and 3 should be solved together) and submit my own PRs.
The text was updated successfully, but these errors were encountered: