Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Switch over to using torch.testing.assert_close in tests #5322

Open
epwalsh opened this issue Jul 19, 2021 · 2 comments
Open

Switch over to using torch.testing.assert_close in tests #5322

epwalsh opened this issue Jul 19, 2021 · 2 comments
Milestone

Comments

@epwalsh
Copy link
Member

epwalsh commented Jul 19, 2021

assert_allclose is being deprecated. See pytorch/pytorch#61844.

@epwalsh epwalsh added this to the 2.6 milestone Jul 19, 2021
@dirkgr
Copy link
Member

dirkgr commented Jul 23, 2021

The suggested replacement was only added in torch 1.9.0, so we need to wait until that is the oldest version we support before we tackle this.

@epwalsh
Copy link
Member Author

epwalsh commented Jul 26, 2021

I don't think this is a user-facing change but let me know if I'm wrong. Because as far as I know we only use this in internal tests, and we only run those tests against the latest version of PyTorch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants