-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio 2015 and 2017 libprotobuf for debug is missing (e. g. csgo) #36
Comments
This is semi-intentional. The debug libraries are up to twice the size of the release ones and not required for a regular build. Neither are handled that well by git. Typically, if someone is capable of compiling and debugging, they are also able to compile their own local copy of the protobuf library as well. (That's not to say that we won't add them, and I'm not going to close this out, but that was my own reasoning for not adding them. Not sure how the other team members feel.) |
Thanks, the explanation makes definitely sense. In the meantime I'll compile the lib on my own and will wait what the other team members will say. If I can help here in any way (e. g. compile/upload VS2017 version for you), let me know :-) |
We could use https://git-lfs.github.com/ to host these bins; maybe. |
Yeah, there's really no reason to not have them because of git lfs. |
Adding via Git LFS sounds fine to me. |
See branch on csgo @ lib\win32\debug and compare to lib\win32\release
The text was updated successfully, but these errors were encountered: