Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add ssz support for beacon request types #1004

Open
mattsse opened this issue Jul 2, 2024 · 1 comment · May be fixed by #1099
Open

[Feature] add ssz support for beacon request types #1004

mattsse opened this issue Jul 2, 2024 · 1 comment · May be fixed by #1099
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Jul 2, 2024

Component

rpc

Describe the feature you would like

spec: https://flashbots.github.io/relay-specs/#/

blocks can be submitted as josn or ssz

we currently don't have ssz support for the submit types:

/// Submission for the `/relay/v1/builder/blocks` endpoint (Deneb).
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
#[cfg_attr(feature = "ssz", derive(ssz_derive::Decode, ssz_derive::Encode))]
pub struct SignedBidSubmissionV3 {

TODO

  • add ssz support, payload types already have ssz:
    #[serde(rename_all = "camelCase")]
    #[cfg_attr(feature = "ssz", derive(ssz_derive::Encode, ssz_derive::Decode))]
    pub struct ExecutionPayloadV1 {

see also:
https://github.com/flashbots/builder/blob/df9c765067d57ab4b2d0ad39dbb156cbe4965778/builder/relay.go#L137-L154C31
https://github.com/attestantio/go-builder-client/blob/73e0a0b2ce80aac4db7705ac3af06e6b85b0d64a/api/deneb/submitblockrequest_ssz.go#L14

Additional context

No response

@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Jul 2, 2024
@programskillforverification

I want to try this. Could you assign to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants