Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add getters to alloy_network_primitives::TransactionResponse #1297

Closed
emhane opened this issue Sep 16, 2024 · 2 comments · Fixed by #1328
Closed

[Feature] Add getters to alloy_network_primitives::TransactionResponse #1297

emhane opened this issue Sep 16, 2024 · 2 comments · Fixed by #1328
Labels
debt Tech debt which needs to be addressed

Comments

@emhane
Copy link
Member

emhane commented Sep 16, 2024

Component

rpc

Describe the feature you would like

Add all getters for all fields of alloy_rpc_types_eth::Transaction as trait methods to alloy_network_primitives::TransactionResponse

Additional context

No response
@emhane emhane added the debt Tech debt which needs to be addressed label Sep 16, 2024
@emhane
Copy link
Member Author

emhane commented Sep 21, 2024

also this one @garwahl?

@garwahl
Copy link
Contributor

garwahl commented Sep 21, 2024

Yep can take this one too, thanks

@garwahl garwahl mentioned this issue Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add getters into TransactionResponse and update implementations garwahl/alloy
2 participants
@garwahl @emhane