Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add getters of alloy_consensus::Header to a new trait BlockHeader #1301

Closed
emhane opened this issue Sep 17, 2024 · 6 comments · Fixed by #1302
Closed

[Feature] Add getters of alloy_consensus::Header to a new trait BlockHeader #1301

emhane opened this issue Sep 17, 2024 · 6 comments · Fixed by #1302
Labels
debt Tech debt which needs to be addressed

Comments

@emhane
Copy link
Member

emhane commented Sep 17, 2024

Component

consensus, eips, genesis

Describe the feature you would like

Add new trait, called something like BlockHeader. Add a getter for all fields of alloy_consensus::Header as trait methods to this new trait. Set the new trait as trait bound for alloy_network::Network.

Additional context

No response

@klkvr
Copy link
Member

klkvr commented Sep 18, 2024

@emhane we already have HeaderResponse trait which is set as bound to header response types on Network, couldn't we extend that?

pub trait HeaderResponse {

@emhane
Copy link
Member Author

emhane commented Sep 18, 2024

ConfigurEvmEnv trait in reth deals with the consensus block type @klkvr

@emhane
Copy link
Member Author

emhane commented Sep 21, 2024

@garwahl would you like to do this one?

@garwahl
Copy link
Contributor

garwahl commented Sep 21, 2024

@emhane Yep happy to take this! Feel free to assign me

@garwahl
Copy link
Contributor

garwahl commented Sep 22, 2024

@emhane this looks completed by #1302 already? Unless I'm mistaken

@emhane
Copy link
Member Author

emhane commented Sep 22, 2024

true, thanks @garwahl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants