Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Unify Transaction and TransactionResponse trait #1344

Closed
mattsse opened this issue Sep 24, 2024 · 1 comment · Fixed by #1387
Closed

[Feature] Unify Transaction and TransactionResponse trait #1344

mattsse opened this issue Sep 24, 2024 · 1 comment · Fixed by #1387
Assignees
@emhane
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.0

Comments

@mattsse
Copy link
Member

mattsse commented Sep 24, 2024

Component

consensus, eips, genesis

Describe the feature you would like

trait TransactionResponse: Transaction {
  // fns for block context
}

ref

#1328 (comment)

cc @garwahl

Additional context

No response
@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Sep 24, 2024
@garwahl
Copy link
Contributor

garwahl commented Sep 24, 2024

Yep I'll take this

@yash-atreya yash-atreya added this to the 1.0 milestone Sep 26, 2024
@emhane emhane self-assigned this Sep 26, 2024
@emhane emhane mentioned this issue Sep 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emhane emhane

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add supertrait alloy_consensus::Transaction to RPC TransactionResponse alloy-rs/alloy
4 participants
@garwahl @mattsse @yash-atreya @emhane