Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make prague field and enum #1557

Open
mattsse opened this issue Oct 24, 2024 · 1 comment · May be fixed by #1574
Open

[Feature] Make prague field and enum #1557

mattsse opened this issue Oct 24, 2024 · 1 comment · May be fixed by #1574
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Oct 24, 2024

Component

rpc

Describe the feature you would like

starting with prague the CL sends a list of requests alongside the actual payload:

/// The EIP-7685 requests provided as additional request params to `engine_newPayloadV4` that
/// are not present in the `ExecutionPayload`.
prague: Option<Requests>,

the requests are never stored be the EL because not part of the block.
to mimick consensus, mostly for testing this makes it difficult and we want a way to provide just the requests hash instead

TODO

  • introduce an enum that has either a list of requests or an hash
  • expose a requests_hash function on that enum

Additional context

No response

@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Oct 24, 2024
@0xriazaka
Copy link
Contributor

Can i take this?

@DoTheBestToGetTheBest DoTheBestToGetTheBest linked a pull request Oct 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@mattsse @0xriazaka and others