Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signer): sign dynamic typed data #235

Merged
merged 15 commits into from
Mar 12, 2024

Conversation

evchip
Copy link
Contributor

@evchip evchip commented Feb 27, 2024

Motivation

Resolves issue #202.

Solution

Add methods sign_dynamic_typed_data and sign_dynamic_typed_data_sync to the Signer and SignerSync traits, respectively.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Cargo.toml Outdated Show resolved Hide resolved
crates/signer/src/signer.rs Outdated Show resolved Hide resolved
crates/signer/src/signer.rs Outdated Show resolved Hide resolved
@evchip
Copy link
Contributor Author

evchip commented Mar 5, 2024

Fixed issues with the formatting. It looks like the CI tests are failing because of a compilation issue:

error[E0432]: unresolved import `alloy_sol_types`
 --> crates/signer/src/signer.rs:8:5
  |
8 | use alloy_sol_types::{Eip712Domain, SolStruct};
  |     ^^^^^^^^^^^^^^^ use of undeclared crate or module `alloy_sol_types`

I don't believe I made any changes that caused this. Anything I need to should be doing to fix this @DaniPopes?

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Missing just formatting.

@evchip
Copy link
Contributor Author

evchip commented Mar 6, 2024

Thanks! Missing just formatting.

@DaniPopes Fixed! Thanks for your help.

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase (sorry about that), otherwise lgtm

… and private_key.rs to reflect changes from upstream
@evchip
Copy link
Contributor Author

evchip commented Mar 12, 2024

needs a rebase (sorry about that), otherwise lgtm

@onbjerg Thanks for the review. I believe I resolved all of the merge conflicts.

@onbjerg onbjerg changed the title Feat(signer): sign dynamic typed data feat(signer): sign dynamic typed data Mar 12, 2024
@onbjerg onbjerg merged commit 471e75c into alloy-rs:main Mar 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants