Feat: enable default features for coins_bip39 to export default wordlist
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
DaniPopes
requested changes
Mar 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #308
Prevents users from having to import
coins_bip39themselves to use the wordlist, achieving the same user experience as inether-rs.alloy/crates/signer/src/lib.rs
Lines 37 to 38 in 818b3e9
Solution
Enables default features.
This change is already included as part of #291 but if we decide to move the examples folder out this is required as part of it.
PR Checklist