Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Embed consensus types in rpc types wherever possible #399

Closed
prestwich opened this issue Mar 26, 2024 · 0 comments · Fixed by #396
Closed

[Feature] Embed consensus types in rpc types wherever possible #399

prestwich opened this issue Mar 26, 2024 · 0 comments · Fixed by #396

Comments

@prestwich
Copy link
Member

prestwich commented Mar 26, 2024

          the way to enforce it as a bound on network (if we even want to do that) would be to have `type TransactionResponse: RpcObject + AsRef<Self::TxEnvelope>`, basically. That would ensure that any response object contained an envelope

I think that the longer we go without embedding consensus objects in the RPC types, the worse of a time we'll have making the change

My primary target list is

  • Log
  • TxEnvelope (deferred for now)
  • ReceiptEnvelope

Originally posted by @prestwich in #361 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant