Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Mark TxEnvelope and ReceiptEnvelope non-exhaustive #451

Closed
prestwich opened this issue Apr 3, 2024 · 3 comments
Closed

[Bug] Mark TxEnvelope and ReceiptEnvelope non-exhaustive #451

prestwich opened this issue Apr 3, 2024 · 3 comments
Labels
bug Something isn't working debt Tech debt which needs to be addressed

Comments

@prestwich
Copy link
Member

Component

consensus, eips, genesis

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

Ethereum may hard fork to add new tx and receipt types
@prestwich prestwich added bug Something isn't working debt Tech debt which needs to be addressed labels Apr 3, 2024
@yash-atreya
Copy link
Member

By "mark" do you mean just add a note in the docs of these types?

@prestwich
Copy link
Member Author

add the #[non_exhaustive] attribute

@yash-atreya yash-atreya mentioned this issue Apr 3, 2024
Merged
3 tasks
@yash-atreya
Copy link
Member

Can be closed #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working debt Tech debt which needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestwich @yash-atreya