Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up legacy serde helpers #624

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

prestwich
Copy link
Member

Closes #479

Motivation

Several serde helpers were carried forward from ethers without being necessary in alloy.

Solution

  • Delete unnecessary helpers
  • rename helpers to *_via_ruint to make behavior clearer

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the debt Tech debt which needs to be addressed label Apr 24, 2024
@prestwich prestwich self-assigned this Apr 24, 2024
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestwich prestwich merged commit e1d45b4 into main Apr 24, 2024
18 checks passed
@prestwich prestwich deleted the prestwich/serde-helper-cleanup branch April 24, 2024 15:38
mattsse pushed a commit to foundry-rs/block-explorers that referenced this pull request May 1, 2024
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* refactor: clean up legacy serde helpers

* doc: fixlink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Debt] Clean up serde helpers and remove redundant code
2 participants