Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add engine api extension #658

Closed
mattsse opened this issue May 1, 2024 · 3 comments · Fixed by #676
Closed

[Feature] Add engine api extension #658

mattsse opened this issue May 1, 2024 · 3 comments · Fixed by #676
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented May 1, 2024

Component

provider, pubsub, rpc

Describe the feature you would like

mostly for testing purposes, it would be nice to have an EngineApiExt trait similar to

pub trait AdminApi<N, T>: Send + Sync {

see also:

https://github.com/paradigmxyz/reth/blob/0938504f4a265eec74e0b833ab5c41d66649bdee/crates/rpc/rpc-api/src/engine.rs#L27-L27

TODO

  • add extension trait for engine API
  • can use ethereum engine types, but I think eventually we'd need a helper trait because some request params are also network specific
  • should be feature gated because not useful for regular usage

Additional context

No response

@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels May 1, 2024
@leruaa
Copy link
Contributor

leruaa commented May 1, 2024

I can take this on.

@leruaa
Copy link
Contributor

leruaa commented May 6, 2024

@mattsse May I continue on that topic by replacing the trait in Reth https://github.com/paradigmxyz/reth/blob/0938504f4a265eec74e0b833ab5c41d66649bdee/crates/rpc/rpc-api/src/engine.rs#L27-L27 by the new trait from Alloy?

Assuming Alloy rev in Reth will need to be bumped obviously ;)

@mattsse
Copy link
Member Author

mattsse commented May 6, 2024

we still need this because this also generates the server code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants