Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: actually impl from for payload v4 #698

Merged
merged 1 commit into from
May 6, 2024
Merged

chore: actually impl from for payload v4 #698

merged 1 commit into from
May 6, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented May 6, 2024

Motivation

#695 added all the util funcs but did not add the From impl

Solution

Add the From impl 🙃

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg onbjerg added the enhancement New feature or request label May 6, 2024
@DaniPopes DaniPopes merged commit c3ea7bc into main May 6, 2024
24 checks passed
@DaniPopes DaniPopes deleted the onbjerg/ok-actually-implement-from-this-time branch May 6, 2024 13:28
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@onbjerg
chore: actually impl from for payload v4 (alloy-rs#698)
9c1a812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onbjerg @mattsse @DaniPopes