fix: required fields for transactions and receipts #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
this reverts incorrect changes introduced in #523
in transaction info (for example
eth_getTransactionByHash
), these fields are requiredin transaction receipts, there fields are required.
moreover, the original justification is also incorrect, as the author has misunderstood how geth does the serialization. this screencap is freshly out of
geth --dev
. as you can see, the optional fields are present, and the linked code hasn't changed since 2019.Solution
i removed
skip_serializing_if
for required fields.PR Checklist