feat(provider): eth_getAccount support
#760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
May 20, 2024
crates/rpc-types/src/eth/account.rs
Outdated
| @@ -41,6 +41,20 @@ pub struct EIP1186AccountProofResponse { | |||
| pub storage_proof: Vec<EIP1186StorageProof>, | |||
| } | |||
|
|
|||
| /// Response for `eth_getAccount` | |||
| #[derive(Copy, Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)] | |||
| #[serde(rename_all = "camelCase")] | |||
There was a problem hiding this comment.
do we have an Account struct in alloy-consensus? if not i would prefer to push this down and ensure it has RLP encoding
mattsse
requested changes
May 21, 2024
prestwich
requested changes
May 25, 2024
|
yeah, I realized we don't have eip1186 types in the eips crate yet, so I think we should move them separately. |
|
the account struct should be in consensus, as it's an member of the state trie, no? |
|
where do you want me to put this, consensus/account.rs ? |
|
that'd be great. I can get to it in a couple hours if you don't. if you want to merge this before adding the RLP impl, please open an issue to follow up 🫡 |
|
this would introduce alloy-consensus dep in provider, not sure if we want this |
|
don't we already have that indirectly via receipts and txenvelopes? |
|
ah we indeed have this already |
prestwich
approved these changes
May 25, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: eth_getAccount on provider * chore: use rpc with block * move account to consensus --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://t.me/ethers_rs/37923.
Solution
Implement
eth_getAccount.Haven't added a test, as Anvil doesn't implement the method—needs an anvil companion PR
PR Checklist