[Refactor] Nit: align naming of tx_hash
/ transaction_hash
, tx_type
/ transaction_type
#814
Labels
enhancement
New feature or request
Component
consensus, eips, genesis, network, json-rpc, rpc
Describe the feature you would like
A nit, but I noticed an inconsistency when switching between a pending transaction (
.tx_hash()
) and receipt (.transaction_hash
):For
Log
andReceipt
:transaction_hash
is used.For
TxEnvelope
,Heartbeat
,TraceResult
:tx_hash
is used.Another case is
tx_type
andtransaction_type
:For
Transaction
,TransactionReceipt
,TransactionRequest
:transaction_type
is used.For
ReceiptEnvelope
and :tx_type
is used.I propose we align the naming. My preference is
transaction_hash
andtransaction_type
, this is in line withsignature_hash
.Additional context
No response
The text was updated successfully, but these errors were encountered: