Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(provider): reorder methods in Provider trait #863

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Jun 10, 2024

Motivation

Closes #269

Solution

Reordered as per JSON-RPC spec, which follows the alphabetical order.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya changed the title chore(provider): Reorder methods in Provider trait chore(provider): reorder methods in Provider trait Jun 10, 2024
@DaniPopes
Copy link
Member

FYI I've edited the description to use GitHub keywords when referencing issues.

@DaniPopes DaniPopes merged commit b0a97b3 into main Jun 11, 2024
24 checks passed
@DaniPopes DaniPopes deleted the yash/reorder_provider_methods branch June 11, 2024 00:16
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
chore(provider): reorder methods per JSON-RPC spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Reorder functions in Provider trait to be more logical
3 participants