Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unify etherscan url format #23

Merged
merged 3 commits into from
Dec 23, 2023
Merged

chore: unify etherscan url format #23

merged 3 commits into from
Dec 23, 2023

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Dec 23, 2023

no trailing / on all etherscan urls

DaniPopes
DaniPopes requested changes Dec 23, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test and a comment/note for this?

@mattsse
Copy link
Member Author

mattsse commented Dec 23, 2023

done

@mattsse mattsse merged commit 4edcc71 into main Dec 23, 2023
20 checks passed
@DaniPopes DaniPopes deleted the matt/unify-url-format branch December 23, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @DaniPopes