Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve SolType tuples #115

Merged
merged 2 commits into from
Jun 15, 2023
Merged

feat: improve SolType tuples #115

merged 2 commits into from
Jun 15, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

  • remove "tuple" from formatting, since it's not a valid Solidity type
  • avoid allocating in eip712_word
  • return Ok(()) in unit type_check

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes requested a review from prestwich June 14, 2023 23:19
prestwich
prestwich approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good once ci passes

@DaniPopes DaniPopes merged commit 71caa94 into main Jun 15, 2023
@DaniPopes DaniPopes deleted the dani/sol-type-tuples branch June 15, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich