Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove to_rust from most traits #133

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: remove to_rust from most traits #133

merged 1 commit into from
Jun 21, 2023

Conversation

prestwich
Copy link
Member

Motivation

Mostly closes #90

Exception is SolStruct::to_rust for reasons found here:
#90 (comment)

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Jun 20, 2023
@prestwich prestwich self-assigned this Jun 20, 2023
DaniPopes
DaniPopes approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based

@prestwich prestwich merged commit 081143f into main Jun 21, 2023
@DaniPopes DaniPopes deleted the prestwich/remove-to-rust branch June 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Sol* traits' from_rust method to new and remove to_rust
2 participants
@prestwich @DaniPopes