Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add DynSolType::decode_params method #165

Closed
Philogy opened this issue Jul 2, 2023 · 0 comments · Fixed by #166
Closed

[Feature] Add DynSolType::decode_params method #165

Philogy opened this issue Jul 2, 2023 · 0 comments · Fixed by #166
Labels
enhancement New feature or request

Comments

@Philogy
Copy link

Philogy commented Jul 2, 2023

Component

dyn-abi

Describe the feature you would like

Current there's an encode_sequence and encode_single method with each having their decode counter-part decode_single and decode_sequence. However encode_params which supports both single and sequential types has no decode counter-part.

It would be very useful to also have a generic decode method that directly supports both sequential and single types to be able to e.g. do calldata decoding without having to check and switch between the two existing methods.

Additional context

No response

@Philogy Philogy added the enhancement New feature or request label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant