Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] expected u128, found Uint<256, 4> #376

Closed
jnoorchashm37 opened this issue Oct 20, 2023 · 3 comments
Closed

[Bug] expected u128, found Uint<256, 4> #376

jnoorchashm37 opened this issue Oct 20, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@jnoorchashm37
Copy link

Component

sol! macro

What version of Alloy are you on?

No response

Operating System

Linux

Describe the bug

Screenshot 2023-10-19 at 5 31 48 PM

https://etherscan.io/address/0xbb37a88508d464a1bb54cf627d05e39883ae0ef9

@DaniPopes
Copy link
Member

For visibility

#377 (comment)

all these different errors come from the fact that we generate two structs with the same name for BidTooLow, which is both an error and an event

@gakonst
Copy link
Member

gakonst commented Feb 15, 2024

Is the right fix namespacing w/ mod error / events / call types etc?

@DaniPopes
Copy link
Member

DaniPopes commented Aug 21, 2024

I am not sure we can do anything here, the ABI itself has conflicting declarations. I tried these tools and they all either don't generate anything, or generate duplicate definitions like we do:

This is what we currently generate (v0.8.0):

interface Auction {
    type AuctionStatus is uint8;
    struct AuctionData {
        uint256 claimId;
        uint256 tokenId;
        uint48 startTime;
        uint48 endTime;
        uint32 extendedBiddingTime;
        uint64 minBidIncrement;
        bool active;
        bool claimed;
        bool cancelled;
        uint8 basis;
        address highBidder;
        uint64 highBid;
        uint32 lastBidDelta;
    }

    error AddressTarget(address target);
    error AlreadyClaimed(uint256 lotId);
    error AlreadyInitialized();
    error ArrayMismatch();
    error AuctionAborted(uint256 auctionId);
    error AuctionActive(uint256 auctionId);
    error AuctionClosed(uint256 auctionId);
    error AuctionInactive(uint256 auctionId);
    error BadSender(address expected, address caller);
    error BidTooLow(uint256 auctionId, uint256 bid, uint256 minBid);
    error InterfaceNotSupported();
    error OutOfRange(uint256 value);
    error UserPermissions();

    event AuctionAborted(uint256 indexed auctionId, bool indexed refunded, string reason);
    event AuctionAdded(uint256 indexed auctionId, uint48 startTime, uint48 endTime, uint256 indexed claimId, uint256 indexed tokenId);
    event AuctionChanged(uint256 indexed auctionId, uint48 startTime, uint48 endTime, uint256 indexed claimId);
    event AuctionClosed(uint256 indexed auctionId);
    event AuctionEnded(uint256 indexed auctionId, address indexed winner, uint128 indexed bid);
    event AuctionInExtendedBidding(uint256 indexed auctionId);
    event AuctionLotClaimed(uint256 indexed auctionId, uint256 indexed claimId, address indexed winner, address recipient);
    event AuctionProceedsClaimed(uint256 indexed auctionId, address indexed seller, address recipient, uint128 indexed amount);
    event Bid(uint256 indexed auctionId, uint256 when, address indexed bidder, uint128 indexed amount);
    event BidTooLow(uint256 indexed auctionId, uint128 indexed bid, uint128 indexed minHighBid);
    event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);

    function _sellerToken() external view returns (address);
    function _tokenAuctionMap(uint256) external view returns (uint256);
    function abortAuction(uint256 auctionId, bool issueRefund, string memory reason) external;
    function addAuction(uint48 startTime, uint48 endTime, uint32 extendedBiddingTime, uint64 startBid, uint64 increment, uint8 basis, uint256 claimId, address seller) external;
    function auctionStatus(uint256 auctionId) external view returns (AuctionStatus);
    function bid(uint256 auctionId, uint64 amount, bool revertOnFail) external;
    function claimLot(uint256 auctionId, address deliverTo) external;
    function claimProceeds(uint256 auctionId, address deliverTo) external;
    function confirmAuction(uint256 auctionId, address premiumRecipient) external;
    function confirmAuctions(uint256[] memory auctionIds, address[] memory premiumRecipients) external;
    function editAuction(uint256 auctionId, uint48 startTime, uint48 endTime, uint32 extendedBiddingTime, uint64 increment, uint8 basis, uint256 claimId) external;
    function getAuctionMetadata(uint256 auctionId) external view returns (AuctionData memory);
    function isAuctioneer(address account) external view returns (bool);
    function isBroker(address account) external view returns (bool);
    function multiBid(uint256[] memory auctionIds, uint64[] memory amounts, bool revertOnFail) external;
    function owner() external view returns (address);
    function setAuctioneer(address newAuctioneer) external;
    function setBroker(address newBroker) external;
    function setup(address escrow, address sellerToken_, bool requireAuctionVerification_) external;
    function transferOwnership(address newOwner) external;
}

@DaniPopes DaniPopes closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants