feat(dyn-abi): DynSolType::coerce_str
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Oct 21, 2023
Comment on lines
+327
to
+328
| // TODO: escapes? | ||
| let min = if has_delim { 0 } else { 1 }; |
There was a problem hiding this comment.
hmm, good question, maybe this could happen with same escaped json inputs, but I think we can ignore that
Evalir
approved these changes
Oct 21, 2023
crates/dyn-abi/src/coerce.rs
Outdated
Comment on lines
254
to
263
| fn uint_units(input: &mut &str) -> PResult<usize> { | ||
| alpha0(input).and_then(|s| { | ||
| Ok(match s { | ||
| "ether" => 18, | ||
| "gwei" | "nano" | "nanoether" => 9, | ||
| "" | "wei" => 0, | ||
| _ => return Err(ErrMode::from_error_kind(input, ErrorKind::Fail)), | ||
| }) | ||
| }) | ||
| } |
There was a problem hiding this comment.
This is super handy, lets us replace a few utilities we have in foundry
wdyt about adding more units?
There was a problem hiding this comment.
Do you have anything in mind? Solidity only supports wei, gwei, and ether
|
|
||
| assert_eq!( | ||
| DynSolType::Uint(256) | ||
| .coerce_str("0.000000000000000001ether") |
prestwich
reviewed
Oct 22, 2023
|
Added in 0e974a1 @prestwich |
|
perfection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Port of
ethabi::Tokenizer, with extra featuresSolution
PR Checklist