Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Parity round-trip is broken #496

Closed
prestwich opened this issue Jan 23, 2024 · 2 comments
Closed

[Bug] Parity round-trip is broken #496

prestwich opened this issue Jan 23, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@prestwich
Copy link
Member

Component

primitives

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

Parity to_parity_bool was backwards for EIP-155 V values.

noted in alloy-rs/alloy#144 (comment)
@prestwich prestwich added the bug Something isn't working label Jan 23, 2024
@prestwich prestwich mentioned this issue Jan 23, 2024
Merged
3 tasks
@Evalir
Copy link
Contributor

Evalir commented Jan 23, 2024

closed by #497?

@prestwich
Copy link
Member Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestwich @Evalir