Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] SolEvent::decode_raw_log should check the event signature. #589

Closed
ewile opened this issue Apr 2, 2024 · 0 comments · Fixed by #741
Closed

[Bug] SolEvent::decode_raw_log should check the event signature. #589

ewile opened this issue Apr 2, 2024 · 0 comments · Fixed by #741
Labels
bug Something isn't working

Comments

@ewile
Copy link

ewile commented Apr 2, 2024

Component

sol-types

What version of Alloy are you on?

0.7.0

Operating System

None

Describe the bug

Currently, SolEvent::decode_raw_log does not check that its SIGNATURE_HASH matches topic0, in the case of non-anonymous events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sol-types): check signature in SolEvent if non-anonymous alloy-rs/core
1 participant
@ewile