Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Documentation isn't generating correctly for Signature #605

Closed
kayabaNerve opened this issue Apr 17, 2024 · 3 comments · Fixed by #680
Closed

[Bug] Documentation isn't generating correctly for Signature #605

kayabaNerve opened this issue Apr 17, 2024 · 3 comments · Fixed by #680
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@kayabaNerve
Copy link

Component

primitives

What version of Alloy are you on?

No response

Operating System

Other (please specify)

Describe the bug

Searching the documentation for "recover" does not show "Signature::recover", and there are other similarly missing items for Signature.

@kayabaNerve kayabaNerve added the bug Something isn't working label Apr 17, 2024
@DaniPopes DaniPopes added the documentation Improvements or additions to documentation label Apr 17, 2024
@prestwich
Copy link
Member

prestwich commented May 28, 2024

I think this is related to this, which was included in rust 1.77.

cc @DaniPopes I am not sure why the docs.rs build would be on 1.80-nightly and still not be adding the appropriate impls here

@prestwich
Copy link
Member

prestwich commented May 28, 2024

I have confirmed that local generation on 1.78 produces the impl blocks as expected

@DaniPopes
Copy link
Member

I can see them only when passing --document-private-items, otherwise I get the same as docs.rs on both stable and nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants