Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Panic in Parity::inverted #630

Closed
prestwich opened this issue May 17, 2024 · 2 comments · Fixed by #633
Closed

[Bug] Panic in Parity::inverted #630

prestwich opened this issue May 17, 2024 · 2 comments · Fixed by #633
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@prestwich
Copy link
Member

Component

primitives

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

This line needs to handle the 0 case
https://github.com/alloy-rs/core/blob/main/crates/primitives/src/signature/parity.rs#L109
@prestwich prestwich added bug Something isn't working good first issue Good for newcomers labels May 17, 2024
@jafar75
Copy link
Contributor

jafar75 commented May 19, 2024

I can send a PR for this issue
just to be ensured, for 0 case, it must return 0?

@prestwich
Copy link
Member Author

for inverted(0) should return 1. even tho this means the inverted operation is no longer symmetrical. we don't expect real users to ever hit this edge case

@jafar75 jafar75 mentioned this issue May 23, 2024
Merged
3 tasks
@prestwich prestwich linked a pull request May 23, 2024 that will close this issue
fix: handle 0 for inverting eip155 parity. #633
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle 0 for inverting eip155 parity. jafar75/core
2 participants
@prestwich @jafar75