Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default hasher foldhash queries the time #767

Closed
Wollac opened this issue Oct 9, 2024 · 2 comments · Fixed by #771
Closed

Default hasher foldhash queries the time #767

Wollac opened this issue Oct 9, 2024 · 2 comments · Fixed by #771
Labels
bug Something isn't working

Comments

@Wollac
Copy link
Contributor

Wollac commented Oct 9, 2024

Component

primitives

What version of Alloy are you on?

alloy-primitives v0.8.6

Operating System

None

Describe the bug

The recent update to foldhash as the default hasher for map in v0.8.6 introduces a dependency on std::time within foldhash. This poses a problem for targets like zkvm, where time is not available, leading to errors.

This change effectively breaks compatibility with zkvm and potentially other targets lacking std::time. Projects relying on Alloy and targeting these platforms will no longer work successfully.

@Wollac Wollac added the bug Something isn't working label Oct 9, 2024
@DaniPopes
Copy link
Member

I've removed the default in #771, but this is also the default hasher for Hashbrown, so consider opening an issue/PR in foldhash to extend disabling the time query cfg

@DaniPopes
Copy link
Member

I've reverted #771 but gated the default hasher to not include target_os = "zkvm" in #777. I would still recommend making the fix in foldhash since you would encounter this in any hashbrown 0.15 usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants