Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SolType::is_dynamic a constant DYNAMIC #97

Closed
DaniPopes opened this issue Jun 12, 2023 · 0 comments · Fixed by #99
Closed

Make SolType::is_dynamic a constant DYNAMIC #97

DaniPopes opened this issue Jun 12, 2023 · 0 comments · Fixed by #99
Assignees
@prestwich
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Jun 12, 2023 •
edited
Loading

There is nothing done at run-time, so it should be a compile-time constant
@DaniPopes DaniPopes added enhancement New feature or request good first issue Good for newcomers labels Jun 12, 2023
@prestwich prestwich self-assigned this Jun 12, 2023
@prestwich prestwich mentioned this issue Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prestwich prestwich

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change is_dynamic to a const DYNAMIC alloy-rs/core
2 participants
@prestwich @DaniPopes