Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Impl alloy_consensus::SignableTransaction for OpTypedTransaction #315

Closed
emhane opened this issue Nov 29, 2024 · 4 comments
Closed

[Feature] Impl alloy_consensus::SignableTransaction for OpTypedTransaction #315

emhane opened this issue Nov 29, 2024 · 4 comments
Assignees
@ftupas
Labels
A-consensus Area: consensus crate

Comments

@emhane
Copy link
Collaborator

emhane commented Nov 29, 2024

Component

consensus

Describe the feature you would like

Ref paradigmxyz/reth#11433 (comment)

Additional context

No response
@emhane emhane added the A-consensus Area: consensus crate label Nov 29, 2024
@emhane emhane mentioned this issue Nov 29, 2024
Merged
@emhane
Copy link
Collaborator Author

emhane commented Nov 29, 2024

keen on this one @ftupas ?

@ftupas
Copy link

ftupas commented Nov 29, 2024

Hi there yeah I can take it, thanks

@ftupas
Copy link

ftupas commented Nov 29, 2024

Hi @emhane, quick question - how should TxDepositbe handled as it's different from other tx types?

@ftupas ftupas mentioned this issue Nov 29, 2024
Closed
3 tasks
@refcell refcell moved this to Todo in Project Tracking Jan 7, 2025
@emhane
Copy link
Collaborator Author

emhane commented Jan 7, 2025

problematic design, benefits of re-using impl of certain trait methods of SignableTransaction doesn't outweigh the cons of implementing SignableTransaction on deposit variant of OpTypedTransaction

@emhane emhane closed this as completed Jan 7, 2025
@github-project-automation github-project-automation bot moved this from Backlog to In Review in Project Tracking Jan 7, 2025
@emhane emhane moved this from In Review to Done in Project Tracking Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ftupas ftupas

Labels
A-consensus Area: consensus crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: impl SignableTransaction for OpTypedTransaction ftupas/op-alloy
2 participants
@ftupas @emhane