Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

blurEdge not fired on hoverNode #1911

Closed
parthms opened this issue Jun 14, 2016 · 10 comments
Closed

blurEdge not fired on hoverNode #1911

parthms opened this issue Jun 14, 2016 · 10 comments
Assignees

Comments

@parthms
Copy link

parthms commented Jun 14, 2016

Firstly, I wanted to tell you that you have done an excellent job with Vis.js. I absolutely love it.

I think I found a bug, let me know if I'm approaching the problem incorrectly. So here is my interaction options:

interaction: { hover: true, hoverConnectedEdges: false, selectConnectedEdges: false }

Based on these settings, what I'm trying to do is separate the selection of an edge and a node. Meaning you can only select an edge or a node, not a group of them.

The issue at hand is that blurEdge is not fired on hoverNode. If I move the cursor straight from an edge to a node, then the hover styles are not removed from the edge.

@Tooa
Copy link
Member

Tooa commented Dec 12, 2016

Can you please test with the latest visjs version again? We have tackled a few issues related to blurEdge and hoverNode in our latest release.

@bthieurmel
Copy link

Regarding this fiddle https://jsfiddle.net/4zt6a71m/1/, changing ressource vis.js 4.14 to 4.17, it's seems that the problem already exists : passing from edge to a node, blurEdge is not called.

Moreover, now, hoverEdge and blurEdge are called many times staying on same edge.

@Tooa
Copy link
Member

Tooa commented Dec 20, 2016

Indeed you found a bug. Especially, the moving from an edge to a node might be a corner case, which has been not addressed in the code. I cannot promise that the fix will make it into the next release, which is planned for 30.12. However, I might be able to push a fix to the develop branch before next year ;)

@Tooa Tooa self-assigned this Dec 20, 2016
@bthieurmel
Copy link

Ok. Thanks. So waiting for fix and ready to test.

@dockstreet
Copy link
Contributor

This fix would really help out, looking forward to it

@Tooa
Copy link
Member

Tooa commented Jan 7, 2017

@bthieurmel @dockstreet I've created a pull request to resolve the issue here #2554. Can you please test whether it works for you two? There is quite a lot of logic going on in the part I've changed. So, make sure nothing else is broken.

@Tooa Tooa added this to the Minor Release v4.18 milestone Jan 7, 2017
@dockstreet
Copy link
Contributor

dockstreet commented Jan 10, 2017

short answer:
I created a couple of plunkers. This fix seems to work, in regards to this issue

long answer:
That said, I believe I may have uncovered another issue not related to this fix in the current development snapshot with IE11 and network.

When I try to do anything with network in IE11, I get :

'Symbol' is undefined

This which does not occur in vis 4.17.0 with network .
The 'Symbol' is undefined error does not occur in Edge/Chrome/Firefox with the Snapshot 4.18 version, only IE11.

I slightly modfied @bthieurmel's example and created a plunker by pulling from the develop branch in git, as I couldn't refer to the development version on cloudflare or local one with . Then I manually uploaded a minimized version built with npm/node here, as plunker wouldn't accept the whole vis.js file for some quota reason.

Here is my plunker, I would have used jsbin, but blocked by proxy ; and not sure how to reference external files with jsfiddle.

https://plnkr.co/edit/MX1agpoRYgYbgC23NAhl?p=preview

hope this helps & thanks soo much @Tooa & @bthieurmel!

Let me know if there is something I can try next

@Tooa
Copy link
Member

Tooa commented Jan 10, 2017

@dockstreet Can you create a new issue for this problem? It helps to maintain the overall overview.

@dockstreet
Copy link
Contributor

will do & thanks

@mojoaxel
Copy link
Member

fixed by @Tooa with #2554

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants