Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

[enchancement] more options for the edges' endings #1993

Closed
kagestrife opened this issue Jul 27, 2016 · 12 comments
Closed

[enchancement] more options for the edges' endings #1993

kagestrife opened this issue Jul 27, 2016 · 12 comments
Assignees

Comments

@kagestrife
Copy link

kagestrife commented Jul 27, 2016

Other than just an arrow, could we get a circle, a rectangular, etc? This may be trivial, but it's a really important feature, due to the use of different symbols in various graphical standards (i.e. in biology).
I am using the visNetwork library (R Shiny) and the mods there directed me here, to the vis repository.

@mojoaxel
Copy link
Member

@kagestrife Good Idea! What kind of symbols would you like/need?

@kagestrife
Copy link
Author

@mojoaxel Hi and sorry for the late response, I was on vacation and could not comment ASAP.

About the edges' endings, what I would like to be added is an " O ", an " X ", a " | ", a rectangular and maybe a tail " < ".

Let me know if it is doable, and thank you for the help. If I come up with other ideas, I will let you know.

@mojoaxel
Copy link
Member

@kagestrife Do you maybe have any demo chart for this kind of biological data? We would need to create an example for this and "real" data would be nice.

This enhancement could be done in about 1-3 hours. If I see a nice use case for this maybe I'm willing to spend the time ;-)

@kagestrife
Copy link
Author

@mojoaxel It's a particular algorithm that needs this set of icons. An example of a graph like this is: https://encrypted-tbn3.gstatic.com/images?q=tbn:ANd9GcQRB1FsCKIoUPKIhSTGNiFMR2BrITt9bxhBZB7ul3dfzx3gSUtabw

Where instead of circles, X's or |'s might be needed. Also, let us know when the updated version is available. A simple short example on how to use it, would be more than helpful as well.

@mojoaxel
Copy link
Member

@kagestrife Is this an official diagram type? Has this type maybe even a name? Where is it used? I'm asking because it would be much more interesting to provide a often used diagram type instead of implementing something just for you :-)

@kagestrife
Copy link
Author

@mojoaxel Yes, its an official diagram type and its called "Partial Ancestral Graphs".
https://en.wikipedia.org/wiki/Ancestral_graph
There are some algorithms (such as FCI on the package pcalg) that output such graphs, which may use circle endpoints to indicate ambiguous orientations.
But, beyond that, we (or another user) may need some different end points for the edges that are not currently under a known network, such as the ones we were referring before.

@mojoaxel
Copy link
Member

mojoaxel commented Sep 2, 2016

I still have problems finding a definition or something about these "Ancestral Graphs". There are no examples of the symbols you described.

I could take the time to implement this new feature but I would need a specific definition what kind of symbols you want to use and what they should represent.

If that is just something for one specific project, than you must find another way (e.g. drawing an the chart yourself). Sorry.

@kagestrife
Copy link
Author

@mojoaxel , Thanks for your answer.

What we need exactly, is just a different ending point (a small circle instead of an arrow) for some of our network edges, regardless of the type of the network or the method being used.
Just for the record, this is going to be used for the output of the FCI algorithm (R package pcalg, https://cran.r-project.org/web/packages/pcalg/pcalg.pdf).
The circle end-point on an edge represents an ambiguous orientation.
This is a research academic project and the only new feature we need by you is to just give us the ability to use a circle end-point on some edges instead of the classic ones that you already have in your implementation. Is this feasible?

Thanks a lot for your time and regards.

@mojoaxel
Copy link
Member

mojoaxel commented Sep 4, 2016

I'll try to look into this. But I can't promise to do that in the next days...

@mojoaxel
Copy link
Member

mojoaxel commented Oct 3, 2016

this is actually a duplicate of #1444 , but lets keep it open until @kagestrife has what he needs.

@mojoaxel
Copy link
Member

@kagestrife The edge ending "circel" is now implemented in the "develop" branch. Can we close this issue or do you need more edge endings?

@kagestrife
Copy link
Author

@mojoaxel I think for the time being we do not need anything else. Thanks for the help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants