Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Get edge's label from editEdge event #2233

Closed
sawatsky opened this issue Oct 26, 2016 · 3 comments
Closed

Get edge's label from editEdge event #2233

sawatsky opened this issue Oct 26, 2016 · 3 comments

Comments

@sawatsky
Copy link

We should be able to get the label information for edges in the editEdge event.

Currently, we can get label information for nodes from editNode, so it makes sense to be able to get the label from editEdge as well.

This will require adding another event - or adjusting the current events - for editing edges, so that users aren't required to arbitrarily move an edge's link to trigger the editEdge event. Users should be able to edit an edge's label without any other adjustments.

For current workarounds: #2068

@mojoaxel
Copy link
Member

@eymiha are you sure this is fixed with #2329 ?

@eymiha
Copy link
Contributor

eymiha commented Nov 21, 2016

In examples/network/other/manipulationEditEdgeNoDrag.html you can see that now, when editing a labeled edge, the current value is being pulled from the passed data. Unless I really mucked something up it should be working because the label data is loaded in the ManipulationSystem#performEditEdge function.

@mojoaxel
Copy link
Member

@eymiha Yes looks good.
@sawatsky Feel free to reopen if this is still an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants