Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

[Timeline] Tooltip not disappearing on mobile & scrolling. #2572

Closed
lewisjb opened this issue Jan 13, 2017 · 6 comments
Closed

[Timeline] Tooltip not disappearing on mobile & scrolling. #2572

lewisjb opened this issue Jan 13, 2017 · 6 comments
Assignees

Comments

@lewisjb
Copy link
Contributor

lewisjb commented Jan 13, 2017

I have come across two scenarios where the tooltip won't disappear (as mouseout isn't triggered).

  1. On mobile
  2. If you are hovering over an item and scroll

The easiest fix I can think of is to store the current open tooltip in ItemSet, as there logically can only be one open, that way we can force the old one to be hidden before displaying a new one.

@mojoaxel
Copy link
Member

I can confirm that tooltips stay visible at the current position if the user scrolls, moves or zooms the timeline.

@yotamberk
Copy link
Contributor

@lewisjb Can you please take care of this issue? It should be quite straight forward

@lewisjb
Copy link
Contributor Author

lewisjb commented Jan 30, 2017

Would it be more beneficial to only have one tool-tip DOM object, and instead of creating new ones when needed then hiding/showing them, just change it's value etc? Because currently if you have a lot of data in your timeline you can end up with a lot of tooltips in the DOM.

@mojoaxel mojoaxel added this to the Minor Release v4.19 milestone Jan 30, 2017
@yotamberk
Copy link
Contributor

@lewisjb yes! I think only one tooltip should be available at all times

@mojoaxel
Copy link
Member

see #2662

@mojoaxel
Copy link
Member

fixed by @lewisjb with #2662

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants