Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Multiline lines overlap with shapes #2968

Closed
AlexDM0 opened this issue Apr 11, 2017 · 5 comments
Closed

Multiline lines overlap with shapes #2968

AlexDM0 opened this issue Apr 11, 2017 · 5 comments

Comments

@AlexDM0
Copy link
Contributor

AlexDM0 commented Apr 11, 2017

If you use the multiline example and change the database to "dot" the text overlays the node. This can be fixed by individual font offsets but its a dirty fix. The text should never overlap the node.

https://jsbin.com/qapudeguxe/edit?html,output

@ludost
Copy link
Member

ludost commented Apr 18, 2017

Pretty old code already, but can be fixed in ShapeBase.js, by taking the labelHeight into account for determining the y-value.

See patch below:
labelPlacementPatch.txt

@AlexDM0
Copy link
Contributor Author

AlexDM0 commented Apr 19, 2017

Is this the same reason the database shape has wrong text positioning? It's at the top now, it used to be in the center?

@wimrijnders
Copy link
Contributor

@ludost thanks for diff, works with minor modification. Will post a PR based on this.

@wimrijnders
Copy link
Contributor

Is this the same reason the database shape has wrong text positioning? It's at the top now, it used to be in the center?

@AlexDM0 No this is unrelated.

@wimrijnders
Copy link
Contributor

Hereby merged already. Closing this issue.

@mojoaxel mojoaxel added this to the Minor Release v4.20 milestone May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants